NAS-129460 / 24.10 / add more keys to webui.enclosure.dashboard (per UI team) #13859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI has requested that we add some more keys to the new enclosure endpoint. The summary of these keys are below (NOTE: I'm documenting keys that already exist AS WELL AS the new ones. I'm doing this for posterity sake)
For each enclosure object there are the following keys with their definitions:
top_loaded
(i.e. they can never be true at the same time))internal
is a big ambiguous but it's the best we came up with and it's concrete on what it's definition is at this point in time.)For each disk object there are 4 boolean keys that are all exclusive OR's from each other (i.e. only 1 can be true at any given time)
Tested these changes on an internal M40.
TODO: another PR to add the minis in this logic, it seems those are ignored in the
enclosure_class.py::Enclosure
object. Looks like a simple omission when this was written.