NAS-128439 / 24.10 / Send interface events when commit/rollback for network is performed #13850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
requested changes
Jun 6, 2024
| return get_iface_name('alias_interface', item) | ||
|
|
||
|
|
||
| def find_interface_changes(original_datastores: dict, current_datastores: dict) -> typing.List[str]: |
There was a problem hiding this comment.
I'm sorry but no. This function is insanely complex. I don't want to make our network API any more complex than what it already is. This function is unmanageable, frankly. If this is the complexity that is required to send changed events, then we need to not send changed events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It was requested that we send events when commit/rollback for network is performed. Also it was requested that we provide not just the id of the interface in this case but the complete interface details so UI would not have to make a subsequent call.
Proposed Solution
Requested cases have been addressed in following ways: