NAS-129400 / 24.10 / Remove kubernetes implementation #13841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
requested changes
Jun 5, 2024
| ) | ||
| if not dataset: | ||
| test_path = os.path.join('/mnt', dataset_name) | ||
| if await self.middleware.run_in_thread(os.path.exists, test_path): |
There was a problem hiding this comment.
You're creating 2 threads everytime this method is called to perform a shutil.move which is unnecessary.
This is prone to TOCTOU issues as well so you can simply do shutil.move and catch FileNotFoundError since it'll fail if test_path doesn't exist.
sonicaj
force-pushed
the
catalog-apps-integration
branch
from
994d7a2 to
7428fd8
Compare
yocalebo
approved these changes
Jun 5, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes removing kubernetes integration and adding basic integration for new catalog management.
(Docker is not configurable with these changes atm and neither are we creating it's state atm (mounting apps dataset changes will be reflected in the next PR as well), those changes will be introduced in another PR)