Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129370 / 24.10 / Minor logical fix in enclosure_class._get_model_and_controller #13831

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

creatorcary
Copy link
Contributor

Catch ValueError instead of KeyError when accessing ControllerModels values with parentheses (line 118). Python enums throw ValueError when using parentheses.

@creatorcary creatorcary requested a review from a team June 3, 2024 14:03
@creatorcary creatorcary self-assigned this Jun 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jun 3, 2024

Jira label ignored, branch name already named after an existing ticket.

@bugclerk
Copy link
Contributor

bugclerk commented Jun 3, 2024

@bugclerk bugclerk changed the title Minor logical fix in enclosure_class._get_model_and_controller NAS-129370 / 24.10 / Minor logical fix in enclosure_class._get_model_and_controller Jun 3, 2024
@truenas truenas deleted a comment from bugclerk Jun 3, 2024
@creatorcary creatorcary merged commit 9b7d383 into master Jun 3, 2024
3 checks passed
@creatorcary creatorcary deleted the NAS-129369 branch June 3, 2024 17:54
@bugclerk
Copy link
Contributor

bugclerk commented Jun 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants