NAS-128919 / 24.04.2 / Show only pods which are running when retrieving choices for pod console access #13826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
sonicaj
reviewed
Jun 2, 2024
src/middlewared/middlewared/plugins/chart_releases_linux/resources.py
Outdated
Show resolved
Hide resolved
sonicaj
approved these changes
Jun 6, 2024
yocalebo
approved these changes
Jun 7, 2024
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-128919 is targeted to the following versions which have not received their corresponding PRs: 24.10 |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were showing pods which were no longer running for console access choices which would obviously not work as the pod is no longer active.
Solution
Make sure only those pods are shown as valid for pod console access choices which are actually running at that time.