NAS-127697 / 24.04-RC.1 / Allow RDMA capable interfaces to be exposed for regular networking (by bmeagherix) #13299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JBOF support was added, we added *all* RDMA interfaces to rdma.interface.internal_interfaces. Instead only add those currently in use for JBOF purposes. Likewise, in rdma.get_link_choices omit any interfaces that have been configured for general networking. (cherry picked from commit b2d72ac)
Move rdma.get_configured_interfaces to interface.get_configured_interfaces and reimplement (cherry picked from commit f9a330c)
bmeagherix
approved these changes
Mar 8, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JBOF support was added, we added all RDMA interfaces to
rdma.interface.internal_interfaces. Instead only add those currently in use for JBOF purposes.Likewise, in
rdma.get_link_choicesomit any interfaces that have been configured for general networking.Original PR: #13289
Jira URL: https://ixsystems.atlassian.net/browse/NAS-127697