Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-127698 / 24.10 / Fix temporary mount of system dataset during move #13286

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

anodos325
Copy link
Contributor

When moving the system dataset to a new pool we first temporarily mount the system dataset in the middleware run directory before running rsync to copy all of the data to the new path. During a recent refactor of the system dataset heirarchy the nuance of the temporary mount point was lost.

@bugclerk bugclerk changed the title Fix temporary mount of system dataset during move NAS-127698 / 24.10 / Fix temporary mount of system dataset during move Mar 6, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Mar 6, 2024

When moving the system dataset to a new pool we first temporarily
mount the system dataset in the middleware run directory before
running rsync to copy all of the data to the new path. During
a recent refactor of the system dataset heirarchy the nuance of
the temporary mount point was lost.
@anodos325 anodos325 force-pushed the fix-systemdataset-move branch from 0813dc2 to bde47c9 Compare March 6, 2024 12:45
@anodos325 anodos325 removed the WIP label Mar 6, 2024
@anodos325 anodos325 requested review from Qubad786 and yocalebo March 6, 2024 12:46
@anodos325 anodos325 merged commit b8580e1 into master Mar 6, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the fix-systemdataset-move branch March 6, 2024 12:54
@bugclerk
Copy link
Contributor

bugclerk commented Mar 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants