Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-127671 / 24.04.0 / Fix error message for errors umounting sysdataset (by anodos325) #13284

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Mar 4, 2024

This commit does the following:

  1. Fixes a bug whereby query for processes owned by paths would not list the paths within the paths variable in output
  2. Adds ability to pass a parameter to include files opened by the middlewared process in the output to assist in troubleshooting issues where the middlewared process is what is preventing system dataset umount from occurring.
  3. Passes new parameter when handling errors during systemdataset setup.
  4. Parses the recursive umount error message for the dataset that failed and pass that to the call to look up processes.

Original PR: #13283
Jira URL: https://ixsystems.atlassian.net/browse/NAS-127671

This commit does the following:

1. Fixes a bug whereby query for processes owned by paths would not
   list the paths within the `paths` variable in output
2. Adds ability to pass a parameter to include files opened by
   the middlewared process in the output to assist in troubleshooting
   issues where the middlewared process is what is preventing system
   dataset umount from occuring.
3. Passes new parameter when handling errors during systemdataset
   setup.
4. Parses the recursive umount error message for the dataset that failed
   and pass that to the call to look up processes.

(cherry picked from commit 3081a48)
@anodos325 anodos325 merged commit b449706 into stable/dragonfish Mar 5, 2024
2 checks passed
@anodos325 anodos325 deleted the NAS-127671-24.04.0 branch March 5, 2024 10:51
@bugclerk
Copy link
Contributor Author

bugclerk commented Mar 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants