Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
yocalebo committed Jul 25, 2024
1 parent ed3cdd4 commit 5e2518f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tests/api2/test_001_ssh.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ def test_007_check_local_accounts(ws_client, account):
fail(f'Group has unexpected name: {account["name"]} -> {entry["group"]}')


@pytest.mark.skip(reason='known issue c.f. NAS-127825')
def test_008_check_root_dataset_settings(ws_client):
data = SSH_TEST('cat /conf/truenas_root_ds.json', user, password)
if not data['result']:
Expand Down Expand Up @@ -146,7 +145,10 @@ def test_008_check_root_dataset_settings(ws_client):
# This is a run where root filesystem is unlocked. Don't obther checking remaining
continue

for opt in fhs_entry['options']:
# FIXME: c.f. NAS-127825
# NOSUID is broken at boot, OS team is aware but fix is complicated.
# Skip this specific property for now.
for opt in filter(lambda x: x != 'NOSUID', fhs_entry['options']):
if opt not in fs['mount_opts']:
assert opt in fs['mount_opts'], f'{opt}: mount option not present for {mp}: {fs["mount_opts"]}'

Expand Down

0 comments on commit 5e2518f

Please sign in to comment.