Fix potential memory leak in fs/nfsd/nfs4_acl.c

Issue was spotted during review process for porting to kernel 6.1.
truenas · May 22, 2023 · 5462836 · 5462836
1 parent d02ac88
commit 5462836
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
@@ -262,8 +262,10 @@ get_nfs4_nfsv41xdr_acl(struct svc_rqst *rqstp, struct dentry *dentry,
 		return -ENOMEM;
 
 	len = vfs_getxattr(&init_user_ns, dentry, NA41_NAME, xdr_buf, xdr_buf_sz);
-	if (len == 0)
-		return -EOPNOTSUPP;
+	if (len == 0) {
+		error = -EOPNOTSUPP;
+		goto out;
+	}
 
 	if (len < 0) {
 		switch (len) {