Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-1055 / 25.04 / Pd 1055 add fast deduplication content #3438

Merged
merged 47 commits into from
Feb 12, 2025

Conversation

micjohnson777
Copy link
Contributor

This PR updates the ZFS Deduplication reference article content with information on fast deduplication.

It updates the ManagePoolsSCALE.md article with information on adding a dedup VDEV and the new Prune and Set Qutoa links on the ZFS Health widget found on the Storage Dashboard.

It updates the DatasetsSCALE.md article with information best practices regarding adding deduplication to a dataset.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This commit updates the ZFSDeduplication.md reference article with information on fast deduplication.
…ntent

This commit adds deduplication content to both the ManagePoolsSCALE.md and DatasetSCALE.md articles.
It includes the limitation and new dialogs associated with the new Prune and Set Qutoa dialogs and links added to the ZFS Health widget on the Storage Dashboard.
It also includes information on storage of the DDT based upon how dedup is set up.
@micjohnson777 micjohnson777 requested a review from a team as a code owner January 15, 2025 22:29
@micjohnson777 micjohnson777 marked this pull request as draft January 15, 2025 22:29
@bugclerk bugclerk changed the title Pd 1055 add fast deduplication content PD-1055 / 25.04 / Pd 1055 add fast deduplication content Jan 15, 2025
@bugclerk
Copy link
Contributor

This commit makes minor changes to expands by removing (click here) from the titles of them, and updates the ZFS Health widget content.
It also adds content and screenshots for the Prune and Set Quota options associated with deduplication.
Copy link
Member

@william-gr william-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but would be good to get a quick review from @amotin too

content/SCALE/SCALETutorials/Datasets/DatasetsSCALE.md Outdated Show resolved Hide resolved
@micjohnson777 micjohnson777 requested a review from amotin January 22, 2025 17:05
Added description to line 99
@micjohnson777
Copy link
Contributor Author

Added amotin as a reviewere per William's suggestion.

content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/SCALE/SCALETutorials/Datasets/DatasetsSCALE.md Outdated Show resolved Hide resolved
content/SCALE/SCALETutorials/Datasets/DatasetsSCALE.md Outdated Show resolved Hide resolved
content/SCALE/SCALETutorials/Storage/ManagePoolsScale.md Outdated Show resolved Hide resolved
@micjohnson777 micjohnson777 requested a review from amotin January 29, 2025 15:39
micjohnson777 and others added 4 commits January 29, 2025 13:55
This commit adds section headers for each section detailing the four fast dedup processes, DDT log, prefetch, pruning, and quota
Remove the extra comments about quota in line 44
amotin
amotin previously approved these changes Jan 30, 2025
@linzi-ix linzi-ix added the Technical Writer Review (LM) A technical writer is reviewing the PR. label Feb 6, 2025
Copy link
Contributor

@linzi-ix linzi-ix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments/suggestions

content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
content/References/ZFSDeduplication.md Outdated Show resolved Hide resolved
@linzi-ix linzi-ix merged commit e87de4e into master Feb 12, 2025
3 checks passed
@linzi-ix linzi-ix deleted the PD-1055-Add-Fast-Deduplication-Content branch February 12, 2025 16:59
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/PD-1055 is targeted to the following versions which have not received their corresponding PRs: 25.10

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Re-Review Technical Writer Review (LM) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants