Skip to content

Commit

Permalink
update naming convention
Browse files Browse the repository at this point in the history
  • Loading branch information
stavros-k committed Mar 11, 2023
1 parent 436a383 commit 192aa54
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions library/common/docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -242,15 +242,15 @@ image:
You can define additional images using the following convention:

```yaml
imageWorker:
workerImage:
repository: ""
tag: ""
pullPolicy: IfNotPresent
```

There isn't anything special in the above format (`imageSomething`), it's just a convention.
There isn't anything special in the above format (`nameImage`), it's just a convention.
It's also a format that some external tools can use for automatic image updates.
For example, `Renovate`
For example, [Renovate](https://docs.renovatebot.com/modules/manager/helm-values/#additional-information)

---

Expand Down
2 changes: 1 addition & 1 deletion library/common/templates/app_functions/_permissions.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ GID: GID to change permissions to
{{ $containerName }}:
enabled: true
type: {{ $type }}
imageSelector: imageBash
imageSelector: bashImage
resources:
limits:
cpu: 1000m
Expand Down
2 changes: 1 addition & 1 deletion library/common/templates/app_functions/_postgres.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ resources (required): Resources for the postgres container
{{ $name }}:
enabled: true
primary: true
imageSelector: imagePostgres
imageSelector: postgresImage
securityContext:
runAsUser: 999
runAsGroup: 999
Expand Down
4 changes: 2 additions & 2 deletions library/common/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ image:
tag: ""
pullPolicy: IfNotPresent

imageBash:
bashImage:
repository: bash
tag: "4.4.23"
pullPolicy: IfNotPresent

imagePostgres:
postgresImage:
repository: postgres
tag: "15.2"
pullPolicy: IfNotPresent
Expand Down

0 comments on commit 192aa54

Please sign in to comment.