Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.8.1 to 1.9.0 #190

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2021

Bumps rubocop from 1.8.1 to 1.9.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.9

New features

Bug fixes

  • #9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. (@koic)
  • #9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. (@koic)
  • #9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. (@dvandersluis)
  • #9387: Fix incorrect auto-correct for Style/NilComparison when using !x.nil? and EnforcedStyle: comparison. (@koic)
  • #9411: Fix false negatives for Style/EvalWithLocation for Kernel.eval and when given improper arguments. (@dvandersluis)
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection when the rescue body returns the exception variable. (@asterite)
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection to not change variables if the exception variable has been reassigned. (@dvandersluis)
  • #9389: Fix an infinite loop error for IncludeSemanticChanges: false of Style/NonNilCheck with EnforcedStyle: comparison of Style/NilComparison. (@koic)
  • #9384: Fix a suggestion message when not auto-correctable. (@koic)
  • #9424: Fix an incorrect auto-correct for Style/ClassMethodsDefinitions when defining class methods with class << self and there is no blank line between method definition and attribute accessor. (@koic)
  • #9370: Fix an incorrect auto-correct for Style/SoleNestedConditional when using nested unless modifier multiple conditional. (@koic)
  • #9406: Fix rubocop_todo link injection when YAML doc start sigil exists. (@dduugg)
  • #9229: Fix errors being reported with rubocop -V with an invalid config. (@dvandersluis)
  • #9425: Fix error in Layout/ClassStructure when initializer comes after private attribute macro. (@tejasbubane)

Changes

  • #9415: Change Layout/ClassStructure to detect inline modifiers. (@AndreiEres)
  • #9380: Mark Style/FloatDivision as unsafe. (@koic)
  • #9345: Make Style/AsciiComments allow copyright notice by default. (@koic)
  • #9399: Added AllowedCops configuration to Style/DisableCopsWithinSourceCodeDirective. (@dvandersluis)
  • #9327: Change Layout/EmptyLineAfterMagicComment to accept top-level shareable_constant_values directive. (@tejasbubane)
  • #7902: Change Lint/NumberConversion to detect symbol form of conversion methods. (@tejasbubane)
Changelog

Sourced from rubocop's changelog.

1.9.0 (2021-01-28)

New features

Bug fixes

  • #9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. ([@koic][])
  • #9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. ([@koic][])
  • #9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. ([@dvandersluis][])
  • #9387: Fix incorrect auto-correct for Style/NilComparison when using !x.nil? and EnforcedStyle: comparison. ([@koic][])
  • #9411: Fix false negatives for Style/EvalWithLocation for Kernel.eval and when given improper arguments. ([@dvandersluis][])
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection when the rescue body returns the exception variable. ([@asterite][])
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection to not change variables if the exception variable has been reassigned. ([@dvandersluis][])
  • #9389: Fix an infinite loop error for IncludeSemanticChanges: false of Style/NonNilCheck with EnforcedStyle: comparison of Style/NilComparison. ([@koic][])
  • #9384: Fix a suggestion message when not auto-correctable. ([@koic][])
  • #9424: Fix an incorrect auto-correct for Style/ClassMethodsDefinitions when defining class methods with class << self and there is no blank line between method definition and attribute accessor. ([@koic][])
  • #9370: Fix an incorrect auto-correct for Style/SoleNestedConditional when using nested unless modifier multiple conditional. ([@koic][])
  • #9406: Fix rubocop_todo link injection when YAML doc start sigil exists. ([@dduugg][])
  • #9229: Fix errors being reported with rubocop -V with an invalid config. ([@dvandersluis][])
  • #9425: Fix error in Layout/ClassStructure when initializer comes after private attribute macro. ([@tejasbubane][])

Changes

  • #9415: Change Layout/ClassStructure to detect inline modifiers. ([@AndreiEres][])
  • #9380: Mark Style/FloatDivision as unsafe. ([@koic][])
  • #9345: Make Style/AsciiComments allow copyright notice by default. ([@koic][])
  • #9399: Added AllowedCops configuration to Style/DisableCopsWithinSourceCodeDirective. ([@dvandersluis][])
  • #9327: Change Layout/EmptyLineAfterMagicComment to accept top-level shareable_constant_values directive. ([@tejasbubane][])
  • #7902: Change Lint/NumberConversion to detect symbol form of conversion methods. ([@tejasbubane][])
Commits
  • c95412e Cut 1.9.0
  • bd20cc7 Update Changelog
  • 160e5df Fix an incorrect auto-correct for Style/ClassMethodsDefinitions
  • ad85a55 Add new InternalAffairs/RedundantLetRuboCopConfigNew cop
  • e916e9a Merge pull request #9426 from tejasbubane/fix-9425
  • 39b9f82 [Fix #9425] Fix error in Layout/ClassStructure when initializer comes after...
  • 4356728 Fix false negatives for Style/EvalWithLocation for Kernel.eval and when g...
  • 1f7d2d2 [Fix #9415] Change Layout/ClassStructure to detect inline modifiers
  • 9a06e84 Fix InternalAffairs/ExampleDescription offenses.
  • c37b550 Add new InternalAffairs/ExampleDescription cop.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 29, 2021
@nikukyugamer nikukyugamer merged commit d812405 into development Jan 30, 2021
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.9.0 branch January 30, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant