Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the capability to create the approval issue in the another repository #142

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sunny-1651
Copy link

@sunny-1651 sunny-1651 commented Oct 21, 2024

This PR aims to fix #122 and could potentially resolve #134 (I have not tested this case but with this update, the developer can tweak his pipeline to make it work)

If given the two env variables target-repository & target-repository-owner then the issue will be created in that repo else in the same.
While adding the functionality the previous format/syntax is not broken and can be used the same way as it was used earlier [also the reason for going ahead with env variables instead of another input].

To verify I used these two runs:

@hcho3
Copy link

hcho3 commented Nov 26, 2024

Any updates on this pull request? Would love to use this feature

@sunny-1651
Copy link
Author

sunny-1651 commented Dec 1, 2024

This PR is ready, I am just waiting on the admin to merge this but you can use it from my repo, it is public

https://github.com/sunny-1651/manual-approval/

just replace trstringer/manual-approval@v1 by sunny-1651/manual-approval@dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants