Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: fix protocol check error of bad magic number due to ssl write dirty data to reused socket fd #96

Merged

Conversation

liucf3995
Copy link
Contributor

No description provided.

@liucf3995
Copy link
Contributor Author

close #95

@liucf3995 liucf3995 force-pushed the bugfix/ssl_write_to_resued_fd branch from 3552261 to 1ad90a4 Compare December 21, 2023 09:51
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1cea869) 81.74052% compared to head (1ad90a4) 81.70184%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #96         +/-   ##
===================================================
- Coverage   81.74052%   81.70184%   -0.03868%     
===================================================
  Files            855         855                 
  Lines          33829       33834          +5     
===================================================
- Hits           27652       27643          -9     
- Misses          6177        6191         +14     
Files Coverage Δ
trpc/runtime/iomodel/reactor/common/io_handler.h 50.00000% <100.00000%> (+50.00000%) ⬆️
.../runtime/iomodel/reactor/default/tcp_connection.cc 90.23256% <50.00000%> (-0.37777%) ⬇️
...time/iomodel/reactor/fiber/fiber_tcp_connection.cc 64.79592% <66.66667%> (-0.15253%) ⬇️

... and 8 files with indirect coverage changes

@helloopenworld helloopenworld merged commit 8dcc565 into trpc-group:main Dec 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants