Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: double close when accept fail #73

Conversation

yujun411522
Copy link
Contributor

double close when accept fail

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #73 (13f0621) into main (91aa248) will increase coverage by 0.15414%.
The diff coverage is 100.00000%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #73         +/-   ##
===================================================
+ Coverage   81.59533%   81.74947%   +0.15413%     
===================================================
  Files            855         855                 
  Lines          33736       33736                 
===================================================
+ Hits           27527       27579         +52     
+ Misses          6209        6157         -52     
Files Coverage Δ
...pc/runtime/iomodel/reactor/default/tcp_acceptor.cc 88.67925% <100.00000%> (+1.88679%) ⬆️
...pc/runtime/iomodel/reactor/default/uds_acceptor.cc 87.50000% <100.00000%> (+2.08333%) ⬆️
...pc/runtime/iomodel/reactor/fiber/fiber_acceptor.cc 75.75758% <100.00000%> (+24.24243%) ⬆️

... and 6 files with indirect coverage changes

@yujun411522 yujun411522 force-pushed the bugfix/double_close_when_accept_fail branch from cdce782 to 5d73d03 Compare November 2, 2023 03:08
@yujun411522 yujun411522 force-pushed the bugfix/double_close_when_accept_fail branch from 5d73d03 to 13f0621 Compare November 2, 2023 08:48
@helloopenworld helloopenworld merged commit ef36f11 into trpc-group:main Nov 3, 2023
4 checks passed
@yujun411522 yujun411522 deleted the bugfix/double_close_when_accept_fail branch January 29, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants