Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: fix the issue of the client-side socket fd cannot be recycled… #108

Conversation

liucf3995
Copy link
Contributor

… in a timely manner when using fiber connection pool, causing the number of close-wait to increase.

… in a timely manner when using fiber connection pool, causing the number of close-wait to increase.
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffcfe9f) 81.79163% compared to head (f386dc1) 81.70584%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #108         +/-   ##
===================================================
- Coverage   81.79163%   81.70584%   -0.08580%     
===================================================
  Files            855         855                 
  Lines          33902       33907          +5     
===================================================
- Hits           27729       27704         -25     
- Misses          6173        6203         +30     
Files Coverage Δ
.../runtime/iomodel/reactor/fiber/fiber_connection.cc 55.08982% <100.00000%> (+0.54437%) ⬆️
...c/runtime/iomodel/reactor/fiber/fiber_connection.h 25.00000% <ø> (ø)
...time/iomodel/reactor/fiber/fiber_tcp_connection.cc 65.50000% <100.00000%> (-0.99747%) ⬇️

... and 11 files with indirect coverage changes

@helloopenworld helloopenworld merged commit 2fdb559 into trpc-group:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants