-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(freezeV2): optimize Stake 2.0 APIs #5260
Merged
halibobo1205
merged 1 commit into
tronprotocol:release_v4.7.2
from
lxcmyf:release_v4.7.2
Jun 7, 2023
Merged
feat(freezeV2): optimize Stake 2.0 APIs #5260
halibobo1205
merged 1 commit into
tronprotocol:release_v4.7.2
from
lxcmyf:release_v4.7.2
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxcmyf
force-pushed
the
release_v4.7.2
branch
16 times, most recently
from
June 6, 2023 10:11
6619d31
to
4bd45d4
Compare
} | ||
break; | ||
} | ||
case ALLOW_OPTIMIZE_LOCK_DELEGATE_RESOURCE: { | ||
case MAX_NUMBER_OF_LOCK_PERIOD: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAX_LOCK_PERIOD_FOR_DELEGATION
maybe better?
lxcmyf
force-pushed
the
release_v4.7.2
branch
8 times, most recently
from
June 7, 2023 05:32
65bb5ef
to
5be8621
Compare
tomatoishealthy
approved these changes
Jun 7, 2023
jwrct
reviewed
Jun 7, 2023
|
||
@Getter | ||
@Setter | ||
public long allowOptimizeLockDelegateResource; | ||
public long maxDelegateLockPeriod; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use of allowCancelAllUnfreezeV2 and maxDelegateLockPeriod.
halibobo1205
approved these changes
Jun 7, 2023
lxcmyf
changed the title
feat(freezeV2): optimize some code logic
feat(freezeV2): optimize Stake 2.0 APIs
Jun 7, 2023
Signed-off-by: liuxincheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimize
cancelallunfreezev2
anddelegateresource
code logicWhy are these changes required?
This PR has been tested by:
Follow up
Extra details