Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize SR’s production order when multi masters exist #4630

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

317787106
Copy link
Contributor

What does this PR do?

  1. when multi master occurs, the master with bigger blockId is elected to produce block
  2. add testcase NodeEntryTest.testDistance

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release_v4.6.0@8b6beb8). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release_v4.6.0    #4630   +/-   ##
=================================================
  Coverage                  ?   54.05%           
  Complexity                ?     7933           
=================================================
  Files                     ?      831           
  Lines                     ?    47180           
  Branches                  ?     5110           
=================================================
  Hits                      ?    25503           
  Misses                    ?    19654           
  Partials                  ?     2023           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@317787106 317787106 changed the title refactor(net): when multi master occurs, the master with bigger block… refactor(net): when multi-master occurs, the master with bigger block… Sep 8, 2022
@317787106 317787106 changed the title refactor(net): when multi-master occurs, the master with bigger block… optimize SR’s production order when multi masters exist Sep 13, 2022
@317787106 317787106 requested a review from xxo1shine September 13, 2022 02:46
@Ualidali21
Copy link

Hey what?

@Ualidali21
Copy link

No project select

@Ualidali21 Ualidali21 mentioned this pull request Sep 13, 2022
@317787106 317787106 merged commit 83de387 into tronprotocol:release_v4.6.0 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants