feat(db): add checkpoint v2 for db inconsistency #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomatoishealthy
force-pushed
the
feature/db-checkpoint-v2
branch
9 times, most recently
from
3209498 to
c1edb8f
Compare
Codecov Report
@@ Coverage Diff @@
## release_v4.6.0 #4614 +/- ##
====================================================
- Coverage 54.40% 54.15% -0.26%
+ Complexity 7980 7976 -4
====================================================
Files 831 832 +1
Lines 47154 47333 +179
Branches 5106 5136 +30
====================================================
- Hits 25655 25634 -21
- Misses 19472 19661 +189
- Partials 2027 2038 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tomatoishealthy
force-pushed
the
feature/db-checkpoint-v2
branch
4 times, most recently
from
70769fa to
2f8f8d0
Compare
halibobo1205
reviewed
Sep 6, 2022
| @@ -55,7 +52,7 @@ protected TronDatabase(String dbName) { | |||
| CommonParameter.getInstance().getStorage().getDbDirectory()).toString(); | |||
| dbSource = | |||
| new RocksDbDataSourceImpl(parentName, dbName, CommonParameter.getInstance() | |||
| .getRocksDBCustomSettings()); | |||
| .getRocksDBCustomSettings(), getDirectComparator()); | |||
halibobo1205
reviewed
Sep 6, 2022
| } | ||
| } | ||
| } | ||
| } |
halibobo1205
reviewed
Sep 6, 2022
| retreat(); | ||
| checkPointV2Store.close(); | ||
| logger.info("checkpoint recover success, block number{}", blockNumber); | ||
| } |
| if ("block".equals(db.getDbName())) { | ||
| currentBlockNum = new BlockCapsule(v.getBytes()).getNum(); | ||
| } | ||
| } |
tomatoishealthy
force-pushed
the
feature/db-checkpoint-v2
branch
from
2f8f8d0 to
a010adb
Compare
tomatoishealthy
commented
Sep 14, 2022
| if (cpList.size() < 3) { | ||
| return; | ||
| } | ||
| for (String cp: cpList.subList(0,3)) { |
There was a problem hiding this comment.
3 ---> length - 3
tomatoishealthy
commented
Sep 14, 2022
| } else { | ||
| Histogram.Timer createV2 = Metrics.histogramStartTimer( | ||
| MetricKeys.Histogram.DB_FLUSH, "create2"); | ||
| createCheckpointV2(); |
There was a problem hiding this comment.
createv2 merge to create
tomatoishealthy
commented
Sep 14, 2022
|
|
||
| dbs.forEach(db -> db.getHead().getRoot().merge(db.getHead())); | ||
| retreat(); | ||
| private void recover(TronDatabase<byte[]> tronDatabase, Map<String, Chainbase> dbMap) { |
There was a problem hiding this comment.
change dbMap to dbs
tomatoishealthy
force-pushed
the
feature/db-checkpoint-v2
branch
4 times, most recently
from
3c89a02 to
6838cd2
Compare
tomatoishealthy
changed the title
tomatoishealthy
force-pushed
the
feature/db-checkpoint-v2
branch
from
6838cd2 to
34764e3
Compare
halibobo1205
approved these changes
Sep 15, 2022
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add checkpoint v2 in case of ungraceful shutdown.
Why are these changes required?
This PR has been tested by: