Efficiency improvements to serve_module_asset() #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some efficiency improvements when serving module assets - helpful when dealing with larger files. 1) readfile() vs file_get_contents() streams larger files and avoids the need to read the whole file into memory first. 2) added 304 Not Modified response to HTTP_IF_MODIFIED_SINCE request. Avoids having to send files if client just wants to check that their cached copy is still valid. 3) is_file() checks if it's a valid file vs file_exists() which returns true for files and directories 4) 403 response code to .php and api.json files is the more common response to attempts to access files that shouldn't be 5) Add Last-Modified header when sending file
Add UTF8 charset to $dsn
|
Thanks! I don't entirely understand it. Let me run this past some people who are far smarter than me. I'm sure what you've done is amazing. I'll be in touch shortly. Hail to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some efficiency improvements when serving module assets - helpful when dealing with larger files.
readfile() vs file_get_contents() streams larger files and avoids the need to read the whole file into memory first.
added 304 Not Modified response to HTTP_IF_MODIFIED_SINCE request. Avoids having to send files if client just wants to check that their cached copy is still valid.
is_file() checks if it's a valid file vs file_exists() which returns true for files and directories
403 response code to .php and api.json files is the more common response to attempts to access files that shouldn't be
Add Last-Modified header when sending file