Repair photos #897
Open
Repair photos #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollepierre
force-pushed
the
repair-photos
branch
from
89ddf84 to
619be86
Compare
trollepierre
commented
Jan 13, 2022
| }) | ||
|
|
||
| it('should delete all the photos of article', () => { | ||
| // Given |
There was a problem hiding this comment.
delete
Suggested change
| // Given |
trollepierre
commented
Jan 13, 2022
| }) | ||
|
|
||
| it('should get dropbox files folder path', () => { | ||
| // Given |
trollepierre
commented
Jan 13, 2022
| }) | ||
|
|
||
| it('should get dropbox files folder path', () => { | ||
| // Given |
trollepierre
commented
Jan 13, 2022
| async function sync(dropboxId) { | ||
| photoRepository.deletePhotosOfArticle(dropboxId) | ||
| const dropboxFilesPath = await DropboxClient.getFilesFolderPaths(dropboxId) | ||
| return CreateArticleGallery.createArticleGallery(dropboxFilesPath, dropboxId) |
There was a problem hiding this comment.
need to test the returned
trollepierre
commented
Jan 13, 2022
| @@ -5,6 +5,10 @@ const PhotosApi = { | |||
| fetch(id) { | |||
| return apiService.get(`articles/${id}/photos`) | |||
| }, | |||
|
|
|||
| update(id) { | |||
| return apiService.put(`admin/articles/${id}/photos`) | |||
trollepierre
commented
Jan 13, 2022
| @@ -84,6 +90,7 @@ | |||
| return { | |||
| isUpdateClicked: false, | |||
| isUpdateChapterClicked: false, | |||
| isUpdatePhotosClicked: false, | |||
trollepierre
commented
Jan 13, 2022
| @@ -260,6 +260,7 @@ function _shareChapterImage(imgLink) { | |||
| .then(_transformToImgLink) | |||
| } | |||
|
|
|||
| // TODO: is different of create-article-gallery.js ??? | |||
There was a problem hiding this comment.
take time to work on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.