Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #450: Do not use an IP resolution method different than the one specified in configuration. #459

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

fdcastel
Copy link
Contributor

@fdcastel fdcastel commented Sep 28, 2023

As per this comment on #450.

There are 3 methods of IP resolution, in order of priority:

  • get_address_cmd()
  • get_address_iface()
  • get_address_remote()

Changes in source code:

  • Moves the checks for "is this method configured?" to outside of get_address_cmd() and get_address_iface();
  • When found one method configured stops looking for other methods if an error occurs;
  • get_address_remote() (the latest, in order) is unchanged.

@fdcastel fdcastel changed the title Fix #450: Do not use an ip resolution method different than the one specified in configuration. Fix #450: Do not use an IP resolution method different than the one specified in configuration. Sep 28, 2023
@troglobit troglobit merged commit c62d719 into troglobit:master Sep 29, 2023
@troglobit
Copy link
Owner

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants