Fix Travis on JRuby-HEAD using explicit opts #547
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://travis-ci.org/troessner/reek/jobs/67756300#L297-L307 This is really only an issue on JRUBY-HEAD where cext.enabled property no longer exists. ```ruby expected: "" got: "jruby: warning: unknown property jruby.cext.enabled\njruby: warning: unknown property jruby.cext.enabled\njruby: warning: unknown property jruby.cext.enabled\njruby: warning: unknown property jruby.cext.enabled\n" (compared using ==) Diff: @@ -1 +1,5 @@ +jruby: warning: unknown property jruby.cext.enabled +jruby: warning: unknown property jruby.cext.enabled +jruby: warning: unknown property jruby.cext.enabled +jruby: warning: unknown property jruby.cext.enabled (RSpec::Expectations::ExpectationNotMetError) ./features/step_definitions/reek_steps.rb:58:in `/^it reports no errors$/' features/configuration_loading.feature:29:in `Then it reports no errors' ``` ref: rspec/rspec-dev#115 ```ru
|
I don't have expert knowledge of jruby so i'm just going to go ahead and trust you on this one.:) |
troessner
pushed a commit
that referenced
this pull request
Jun 22, 2015
Fix Travis on JRuby-HEAD using explicit opts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://travis-ci.org/troessner/reek/jobs/67756300#L297-L307
This is really only an issue on JRUBY-HEAD where cext.enabled property no longer exists.
ref: rspec/rspec-dev#115