Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for P4estMesh #33

Merged
merged 13 commits into from
Jun 28, 2021
Merged

Add support for P4estMesh #33

merged 13 commits into from
Jun 28, 2021

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented May 22, 2021 •
edited
Loading

grafik
grafik
grafik
grafik

sloede
sloede reviewed May 22, 2021
View reviewed changes
src/interpolate.jl Outdated Show resolved Hide resolved
@efaulhaber efaulhaber mentioned this pull request May 24, 2021
Closed
11 tasks
@efaulhaber efaulhaber marked this pull request as ready for review May 24, 2021 14:11
@efaulhaber
Copy link
Member Author

This is basically done, but the P4estMesh needs to be in a Trixi release first, so that we can update the required version here.

@efaulhaber efaulhaber requested a review from sloede May 24, 2021 14:14
sloede
sloede requested changes May 24, 2021
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a 2-3 questions

src/vtktools.jl Show resolved Hide resolved
test/test_2d.jl Outdated Show resolved Hide resolved
@efaulhaber efaulhaber closed this Jun 18, 2021
@efaulhaber efaulhaber reopened this Jun 18, 2021
@efaulhaber efaulhaber closed this Jun 18, 2021
@efaulhaber efaulhaber reopened this Jun 18, 2021
@sloede sloede closed this Jun 18, 2021
@sloede sloede reopened this Jun 18, 2021
@efaulhaber efaulhaber requested a review from sloede June 28, 2021 14:41
@sloede sloede merged commit f32758f into trixi-framework:main Jun 28, 2021
@efaulhaber efaulhaber deleted the p4est-vis branch June 28, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efaulhaber @sloede