Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Cubed Sphere as P4estMesh #667

Closed
wants to merge 13 commits into from
Closed

Implement the Cubed Sphere as P4estMesh #667

wants to merge 13 commits into from

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jun 26, 2021 •
edited
Loading

Closes #584.

@efaulhaber efaulhaber mentioned this pull request Jun 26, 2021
Closed
11 tasks
@ranocha
Copy link
Member

ranocha commented Jun 28, 2021

Could you please also add some basic/brief documentation before closing #584?

@efaulhaber
Copy link
Member Author

Do you mean more documentation for P4estMesh in general? Or documentation for the Cubed Sphere code?

@ranocha
Copy link
Member

ranocha commented Jun 28, 2021

Some general documentation, such as adding a new file joinpath("meshes", "p4est_mesh.md") at

Trixi.jl/docs/make.jl

Lines 53 to 57 in 7871c19

"Meshes" => [
"Tree mesh" => joinpath("meshes", "tree_mesh.md"),
"Structured mesh" => joinpath("meshes", "structured_mesh.md"),
"Unstructured mesh" => joinpath("meshes", "unstructured_quad_mesh.md"),
],

It can be rather brief, though.

@efaulhaber efaulhaber closed this Jun 30, 2021
@efaulhaber efaulhaber deleted the cubed-sphere2 branch September 25, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a new mesh type that uses p4est to manage cell connectivity and mesh refinement
2 participants
@efaulhaber @ranocha