-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHD Multicomponent #449
MHD Multicomponent #449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this LGTM (with some comments). I have not fully reviewed the equation files... if this is also necessary in your opinion, please let me know.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Some minor changes left to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but please fix coverage.
@Cczernik Could you also please show some performance comparisons (e.g., the timer output of the summary callback) for the new systems, at least for the 2D version? For reference, it would be interesting to see how it fares against MHD without multicomponent or against Euler multicomponent. |
@sloede Here you can see an mhd multicomponent example with two components in 2D: |
Why are the time step sizes different (different number of RHS calls)? |
@ranocha I ran the test with different gammas.. my bad. Fixed it: |
Implementing 1D Euler multicomponent equations as well as 1D/2D Ideal MHD multicomponent equations.