Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHD Multicomponent #449

Merged
merged 15 commits into from
Mar 29, 2021
Merged

MHD Multicomponent #449

merged 15 commits into from
Mar 29, 2021

Conversation

Cczernik
Copy link
Contributor

@Cczernik Cczernik commented Feb 17, 2021

Implementing 1D Euler multicomponent equations as well as 1D/2D Ideal MHD multicomponent equations.

@Cczernik Cczernik marked this pull request as ready for review March 18, 2021 15:08
@Cczernik Cczernik requested a review from sloede March 18, 2021 15:08
@Cczernik Cczernik changed the title WIP: MHD Multicomponent MHD Multicomponent Mar 18, 2021
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this LGTM (with some comments). I have not fully reviewed the equation files... if this is also necessary in your opinion, please let me know.

src/Trixi.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_dg2d.jl Show resolved Hide resolved
src/callbacks_step/glm_speed_dg.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_2d.jl Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

@Cczernik Cczernik requested a review from sloede March 29, 2021 08:45
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Some minor changes left to fix.

src/callbacks_step/analysis_dg2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_dg2d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_1d.jl Outdated Show resolved Hide resolved
@Cczernik Cczernik requested a review from sloede March 29, 2021 10:57
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but please fix coverage.

@sloede
Copy link
Member

sloede commented Mar 29, 2021

@Cczernik Could you also please show some performance comparisons (e.g., the timer output of the summary callback) for the new systems, at least for the 2D version? For reference, it would be interesting to see how it fares against MHD without multicomponent or against Euler multicomponent.

src/equations/compressible_euler_multicomponent_1d.jl Outdated Show resolved Hide resolved
src/equations/compressible_euler_multicomponent_1d.jl Outdated Show resolved Hide resolved
src/equations/compressible_euler_multicomponent_1d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_1d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_1d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_1d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_2d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_2d.jl Outdated Show resolved Hide resolved
src/equations/ideal_glm_mhd_multicomponent_2d.jl Outdated Show resolved Hide resolved
@Cczernik
Copy link
Contributor Author

Cczernik commented Mar 29, 2021

@Cczernik Could you also please show some performance comparisons (e.g., the timer output of the summary callback) for the new systems, at least for the 2D version? For reference, it would be interesting to see how it fares against MHD without multicomponent or against Euler multicomponent.

@sloede Here you can see an mhd multicomponent example with two components in 2D:
mhdmulti_ec

and without multicomponent
mhd_ec

@ranocha
Copy link
Member

ranocha commented Mar 29, 2021

Here you can see an mhd multicomponent example with one component in 2D:

Why are the time step sizes different (different number of RHS calls)?

@Cczernik
Copy link
Contributor Author

Here you can see an mhd multicomponent example with one component in 2D:

Why are the time step sizes different (different number of RHS calls)?

@ranocha I ran the test with different gammas.. my bad. Fixed it:
mhdmulti_ec_new

@sloede sloede enabled auto-merge (squash) March 29, 2021 13:28
@Cczernik Cczernik requested review from sloede and ranocha March 29, 2021 15:09
@sloede sloede merged commit 41bb820 into main Mar 29, 2021
@sloede sloede deleted the mhd-multi branch March 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants