Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1185 #1189

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix #1185 #1189

merged 1 commit into from
Jul 28, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jul 28, 2022 •
edited
Loading

Closes #1185. See also #628 - something similar is happening here (type instability in profile view but everything is fine with @code_warntype).

@ranocha ranocha added the performance We are greedy label Jul 28, 2022
@ranocha ranocha requested a review from sloede July 28, 2022 11:25
sloede
sloede approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I do not claim to fully understand it 🤷‍♂️

@ranocha
Copy link
Member Author

ranocha commented Jul 28, 2022

@sloede (or someone else with a Mac): Could you please check the macOS error?

@sloede
Copy link
Member

sloede commented Jul 28, 2022

Do you know why it takes 16 minutes in the job to reach the test package initialization?

@ranocha
Copy link
Member Author

ranocha commented Jul 28, 2022

It needs to precompile OrdinaryDiffEq.jl 😅 - and install and precompile Trixi.jl (before)

@sloede
Copy link
Member

sloede commented Jul 28, 2022

@jlchan @andrewwinters5000 Could anyone of you test this? I still can't install MPI on my Macbook until Julia 1.8 😭

@ranocha
Copy link
Member Author

ranocha commented Jul 28, 2022

Looks like it is JuliaIO/HDF5.jl#997?

@jlchan
Copy link
Contributor

jlchan commented Jul 28, 2022

@jlchan @andrewwinters5000 Could anyone of you test this? I still can't install MPI on my Macbook until Julia 1.8 😭

Building Trixi on this branch now. Do you want me to just run the MPI and threaded tests locally?

@ranocha
Copy link
Member Author

ranocha commented Jul 28, 2022

Yeah, I think running either set would be great. If it works, we can merge this from my point of view and need to wait until the HDF5 issue linked above is fixed

@jlchan
Copy link
Contributor

jlchan commented Jul 28, 2022

Threaded tests run fine on my laptop. Running MPI now.

@jlchan
Copy link
Contributor

jlchan commented Jul 28, 2022

Checked out this branch, and both MPI and threaded tests run on my 2020 Macbook Pro using Julia 1.7.3.

@ranocha
Copy link
Member Author

ranocha commented Jul 28, 2022

Cool, thanks! I will merge this unless someone vetos (@sloede?)

@sloede
Copy link
Member

sloede commented Jul 28, 2022

No veto. Thanks for the support!

@ranocha ranocha merged commit 2467350 into main Jul 28, 2022
@ranocha ranocha deleted the hr/fix_1185 branch July 28, 2022 14:41
@visr visr mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

Assignees
No one assigned
Labels
performance We are greedy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type instability in prolong2mortars! for P4estMesh
3 participants
@ranocha @sloede @jlchan