Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actionbar is always white when using 1.8 clients #297

Closed
FallenCrystal opened this issue Apr 16, 2023 · 6 comments · Fixed by #305
Closed

actionbar is always white when using 1.8 clients #297

FallenCrystal opened this issue Apr 16, 2023 · 6 comments · Fixed by #305
Assignees
Labels
module:bungeecord Related to BungeeCord type:bug Something isn't working as expected
Milestone

Comments

@FallenCrystal
Copy link

FallenCrystal commented Apr 16, 2023

Describe the bug

actionBar is not colorized correctly on 1.8 clients.

How can the bug be reproduced?

install plugin.

public String ca(String text) {return ChatColor.translateAlternateColorCodes('&', text);}
public void actionbar(ProxiedPlayer p, String msg) {p.sendMessage(ChatMessageType.ACTION_BAR, new TextComponent(ca(message)));}

and then. send an actionbar message to the 1.8 client.

actionbar(tester, "&aa&bb&cc&dd&ee");

u can get white string "abcde"

Expected behaviour

correct coloring

Which Spigot fork are you using?

PaperMC

What's your server version?

git-PaperSpigot-f6fba00-99355adc (MC:1.8.8)

Which proxy are you using?

Other (specify below)

What's your proxy version?

NullCordX - 3.7.4

What's the MC version of your client?

1.8

What's the Triton version you're using?

3.8.3, 3.6.0(test)

Additional Information

whether its nullcordx, flamecord, waterfall, or native bungeecord. all have this error (at least when i tested it)
only on 1.8 clients. 1.9+ clients work fine.

@FallenCrystal FallenCrystal added triage Hasn't been manually reviewed type:bug Something isn't working as expected labels Apr 16, 2023
@diogotcorreia
Copy link
Member

Was it working on 3.6.0?
I'm pretty sure this worked before, so it must be a regression.

@diogotcorreia diogotcorreia added this to the 3.8.4 milestone Apr 16, 2023
@diogotcorreia diogotcorreia added regression Something that was working but it isn't anymore module:spigot Related to Spigot/PaperMC and removed triage Hasn't been manually reviewed labels Apr 16, 2023
@diogotcorreia diogotcorreia moved this to Todo in Triton Apr 16, 2023
@FallenCrystal
Copy link
Author

FallenCrystal commented Apr 16, 2023

Was it working on 3.6.0? I'm pretty sure this worked before, so it must be a regression.

nope

3.6.0 is the earliest version I have. so i want to test on it. but still not working.

@FallenCrystal
Copy link
Author

btw only on bungeecord. actionbar sender target is proxiedplayer

@diogotcorreia
Copy link
Member

diogotcorreia commented Apr 16, 2023

Oh... that makes sense, did not notice that.
I think that never worked then, I'll take a look.

However, does it work if you create the BaseComponent correctly?

public String ca(String text) {return ChatColor.translateAlternateColorCodes('&', text);}
public void actionbar(ProxiedPlayer p, String msg) {p.sendMessage(ChatMessageType.ACTION_BAR, TextComponent.fromLegacyText(ca(message)));}

(Notice the change from new TextComponent(...) to TextComponent.fromLegacyText(...))

Also, does it work if Triton isn't installed on the proxy?

@diogotcorreia diogotcorreia added module:bungeecord Related to BungeeCord and removed regression Something that was working but it isn't anymore module:spigot Related to Spigot/PaperMC labels Apr 16, 2023
@FallenCrystal
Copy link
Author

Also, does it work if Triton isn't installed on the proxy?

yes

(Notice the change from to new TextComponent(...)TextComponent.fromLegacyText(...))

i will test later

@FallenCrystal
Copy link
Author

(Notice the change from to new TextComponent(...)TextComponent.fromLegacyText(...))

still

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:bungeecord Related to BungeeCord type:bug Something isn't working as expected
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants