Revert "[LLVM] Update to llvm/llvm-project@1f20eee6dc36" #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1d5e9a2.
|
cc: @antiagainst |
antiagainst
pushed a commit
that referenced
this pull request
Dec 10, 2024
jataylo
pushed a commit
to jataylo/triton
that referenced
this pull request
Dec 11, 2024
…#5341) Reverts triton-lang#5308 This is causing functional regressions in some internal tests (cherry picked from commit 7f2c56a)
jataylo
pushed a commit
to jataylo/triton
that referenced
this pull request
Dec 11, 2024
This relands triton-lang#5392 to enable new arch target since backend support has been added--it doesn't depend on the reverted LLVM upgrade in triton-lang#5341; basic necessary enablement is already included in the current llvm version we're using. (cherry picked from commit f257479)
jataylo
pushed a commit
to jataylo/triton
that referenced
this pull request
Dec 12, 2024
This relands triton-lang#5392 to enable new arch target since backend support has been added--it doesn't depend on the reverted LLVM upgrade in triton-lang#5341; basic necessary enablement is already included in the current llvm version we're using. (cherry picked from commit f257479)
antiagainst
pushed a commit
that referenced
this pull request
Jan 13, 2025
I have "bisected" the current CUDA regression (mentioned [here](#5341)) on A100: ``` git bisect start # bad: [f5a35a31bfe6cbc16bec0c130f2bb3632dbf1fbf] [LV] Add test cases with incorrect IV live-outs. git bisect bad f5a35a31bfe6cbc16bec0c130f2bb3632dbf1fbf # good: [86b69c31642e98f8357df62c09d118ad1da4e16a] [SPIR-V] Fix SPIR-V extension SPV_INTEL_function_pointers: ... # first bad commit: [b8703369daf777706196ff914c0376c27adde3cf] [SLP] Match poison as instruction with the same opcode ``` The failure presents as : ``` Traceback (most recent call last): File "/home/mleventa/dev_projects/repro/repro.py", line 135, in <module> torch.cuda.synchronize() File "/home/mleventa/dev_projects/.venv/lib/python3.10/site-packages/torch/cuda/__init__.py", line 987, in synchronize return torch._C._cuda_synchronize() RuntimeError: CUDA error: an illegal memory access was encountered ``` The failing commit is [`b870336`](llvm/llvm-project#115946) and the last working commit is `2fe947b4`. It's not clear to me the relationship but will investigate. This PR to `llvm-head` is to verify that my repro on A100 matches the internal regression/fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5308
This is causing functional regressions in some internal tests