Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMD] remove redundant LDS bypass checks #5002

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[AMD] remove redundant LDS bypass checks #5002

merged 1 commit into from
Oct 29, 2024

Conversation

binarman
Copy link
Contributor

This PR removes special cases for MFMA -> Dot Operand LDS shortcuts.
Now it is supported by common linear layout infrastructure.

No tests are added, mfma-shortcut.mlir already testing this.

@binarman
[AMD] remove redundant LDS bypass checks
415671c 
This PR removes special cases for MFMA -> Dot Operand LDS shortcuts.
Now it is supported by common linear layout infrastructure.
@antiagainst antiagainst marked this pull request as ready for review October 29, 2024 04:51
@Jokeren
Copy link
Contributor

Jokeren commented Oct 29, 2024

Great! @binarman do you want to work on removing isBlockedToDotShortcut as well?

@binarman
Copy link
Contributor Author

binarman commented Oct 29, 2024 •
edited
Loading

@Jokeren
Yes, but I would like to work on this after #4516 PR is merged.
This will give an opportunity to properly test blocked dotOp linear layouts with all cases(including 3d dots)

@antiagainst antiagainst merged commit 69f656c into triton-lang:main Oct 29, 2024
7 checks passed
Luosuu pushed a commit to Luosuu/triton that referenced this pull request Nov 13, 2024
@binarman @Luosuu
[AMD] remove redundant LDS bypass checks (triton-lang#5002)
c789f21 
This commit removes special cases for MFMA -> Dot Operand
LDS shortcuts. Now it is supported by common linear layout
infrastructure.

No tests are added, mfma-shortcut.mlir already testing this.
guacamoleo pushed a commit to guacamoleo/triton that referenced this pull request Nov 14, 2024
@binarman @guacamoleo
[AMD] remove redundant LDS bypass checks (triton-lang#5002)
17de4f2 
This commit removes special cases for MFMA -> Dot Operand
LDS shortcuts. Now it is supported by common linear layout
infrastructure.

No tests are added, mfma-shortcut.mlir already testing this.
jataylo pushed a commit to jataylo/triton that referenced this pull request Nov 18, 2024
@binarman @jataylo
[AMD] remove redundant LDS bypass checks (triton-lang#5002)
89fb97f 
This commit removes special cases for MFMA -> Dot Operand
LDS shortcuts. Now it is supported by common linear layout
infrastructure.

No tests are added, mfma-shortcut.mlir already testing this.

(cherry picked from commit 69f656c)
jataylo pushed a commit to jataylo/triton that referenced this pull request Nov 18, 2024
@binarman @jataylo
[AMD] remove redundant LDS bypass checks (triton-lang#5002)
d99536d 
This commit removes special cases for MFMA -> Dot Operand
LDS shortcuts. Now it is supported by common linear layout
infrastructure.

No tests are added, mfma-shortcut.mlir already testing this.

(cherry picked from commit 69f656c)
@jataylo jataylo mentioned this pull request Nov 19, 2024
Merged
antiagainst added a commit that referenced this pull request Dec 4, 2024
@jataylo @joviliast
@antiagainst @zhanglx13 @Jokeren @binarman @knwng @jungpark-mlir @peterbell10 @htyu
[AMD] release/3.2.x AMD perf cherry picks (#5191)
2d8093c 
Cherry pick list:
- #4925
- #5053 
- #5019 
- #5002 
- #4935 - required additional cherry picks #4991 and #4951
- #4998 
- #4925 
- #5281 
- #5308 
- All previous LLVM hash PRs before #5308

---------

Co-authored-by: Ilya V <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Lixun Zhang <[email protected]>
Co-authored-by: Keren Zhou <[email protected]>
Co-authored-by: Alexander Efimov <[email protected]>
Co-authored-by: Kyle Wang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
jataylo pushed a commit to jataylo/triton that referenced this pull request Dec 12, 2024
@binarman @jataylo
[AMD] remove redundant LDS bypass checks (triton-lang#5002)
06569e5 
This commit removes special cases for MFMA -> Dot Operand
LDS shortcuts. Now it is supported by common linear layout
infrastructure.

No tests are added, mfma-shortcut.mlir already testing this.

(cherry picked from commit 69f656c)
jataylo added a commit to jataylo/triton that referenced this pull request Dec 18, 2024
@jataylo
[AMD] release/3.2.x AMD perf cherry picks (triton-lang#5191)
93f31aa 
Cherry pick list:
- triton-lang#4925
- triton-lang#5053
- triton-lang#5019
- triton-lang#5002
- triton-lang#4935 - required additional cherry picks triton-lang#4991 and triton-lang#4951
- triton-lang#4998
- triton-lang#4925
- triton-lang#5281
- triton-lang#5308
- All previous LLVM hash PRs before triton-lang#5308

---------

Co-authored-by: Ilya V <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Lixun Zhang <[email protected]>
Co-authored-by: Keren Zhou <[email protected]>
Co-authored-by: Alexander Efimov <[email protected]>
Co-authored-by: Kyle Wang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
(cherry picked from commit 2d8093c)
bertmaher pushed a commit that referenced this pull request Dec 19, 2024
@jataylo @joviliast
@antiagainst @zhanglx13 @Jokeren @binarman @knwng @jungpark-mlir @peterbell10 @htyu @bertmaher
[AMD] release/3.2.x AMD perf cherry picks (#5191)
74abcd4 
Cherry pick list:
- #4925
- #5053
- #5019
- #5002
- #4935 - required additional cherry picks #4991 and #4951
- #4998
- #4925
- #5281
- #5308
- All previous LLVM hash PRs before #5308

---------

Co-authored-by: Ilya V <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Lixun Zhang <[email protected]>
Co-authored-by: Keren Zhou <[email protected]>
Co-authored-by: Alexander Efimov <[email protected]>
Co-authored-by: Kyle Wang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jokeren Jokeren Jokeren approved these changes

@antiagainst antiagainst antiagainst approved these changes

@zhanglx13 zhanglx13 Awaiting requested review from zhanglx13 zhanglx13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binarman @Jokeren @antiagainst