[FRONTEND] Wrap experimental TMA descriptor creation into a helper #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to potentially flush the TMA cache when re-using TMA memory. In order to make it safe we flush the cache for every TMA descriptor created.
Jokeren
approved these changes
Jun 20, 2024
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Differential Revision: D61729239
embg
pushed a commit
to embg/benchmark
that referenced
this pull request
Aug 23, 2024
Summary: This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/benchmark
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 Pull Request resolved: pytorch#2435 X-link: pytorch/FBGEMM#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/benchmark
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 Pull Request resolved: pytorch#2435 X-link: pytorch/FBGEMM#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Aug 23, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: pytorch#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Aug 26, 2024
Summary: X-link: facebookresearch/FBGEMM#124 X-link: pytorch/benchmark#2435 Pull Request resolved: #3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239 fbshipit-source-id: 8ce25b7c230c3f4ad960f76aa0dd29626c8ee4d2
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Aug 26, 2024
Summary: X-link: facebookresearch/FBGEMM#124 Pull Request resolved: #2435 X-link: pytorch/FBGEMM#3027 This PR is a dependency of the grid_constant PR. The API for TMA descriptor fill methods was changed, so I fixed up all usages in fbcode. triton-lang/triton#4179 Reviewed By: minjang Differential Revision: D61729239 fbshipit-source-id: 8ce25b7c230c3f4ad960f76aa0dd29626c8ee4d2
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
…riton-lang#4179) We need to potentially flush the TMA cache when re-using TMA memory. In order to make it safe we flush the cache for every TMA descriptor created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to potentially flush the TMA cache when re-using TMA memory. In order to make it safe we flush the cache for every TMA descriptor created.