nnshah1 re2 package #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update AWS SDK version * Disabling S3 * Revert it back * Update version 'nlohmann-json' * Revert "Update version 'nlohmann-json'" This reverts commit 1d84f4c. * Ignore Azure deprecated warning * Fix up * Set higher version for 'nlohmann-json' * Change version to nlohmann-json * Eanble CXX STD 17 to fix absl linking * Apply same CXX_STANDARD for related third party library (#33) --------- Co-authored-by: GuanLuo <[email protected]> Co-authored-by: GuanLuo <[email protected]>
|
What stopped this from being merged before? |
|
At the time I think all the implications weren't thought through - whether allowing a non pinned version for grpc is a good idea or rather we should pin the system one to be the same |
pvijayakrish
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Allow auto-complete to work alongside ragged batch inputs (#31) * Handle implicit batch dimension for non batching models (#33) * Fix L0_infer--cpu (#40) * check if there are KIND_GPU instance groups before autocompleting * only look at the first instance group in InstancehasKindGPU; clang-format Co-authored-by: Tanmay Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.