Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add BF16 test for python backend #7483

Merged
merged 4 commits into from
Jul 30, 2024
Merged

test: Add BF16 test for python backend #7483

merged 4 commits into from
Jul 30, 2024

Conversation

rmccorm4
Copy link
Contributor

@rmccorm4 rmccorm4 commented Jul 30, 2024 •
edited
Loading

What does the PR do?

Adds testing for the BF16 tensor support in Python Backend added here: triton-inference-server/python_backend#371

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Test plan:

  • L0_backend_python::python_test.py::test_bf16
  • CI Pipeline ID: 17050551

Caveats:

Background

See feature PR.

@rmccorm4 rmccorm4 mentioned this pull request Jul 30, 2024
Merged
20 tasks
@rmccorm4 rmccorm4 added the PR: test Adding missing tests or correcting existing test label Jul 30, 2024
Tabrizian
Tabrizian previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rmccorm4 rmccorm4 requested review from Tabrizian and krishung5 July 30, 2024 19:11
@rmccorm4 rmccorm4 merged commit 69d768d into main Jul 30, 2024
3 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick-pb-bf16 branch July 30, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@krishung5 krishung5 Awaiting requested review from krishung5

Assignees
No one assigned
Labels
PR: test Adding missing tests or correcting existing test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmccorm4 @Tabrizian