Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Python models filtering outputs based on requested outputs #7338

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Jun 10, 2024

What does the PR do?

Add tests to establish the behavior of Python backend filtering outputs based on requested outputs from the client.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/python_backend#366

Where should the reviewer start?

N/A

Test plan:

N/A

  • CI Pipeline ID:
    #15726534
    #15745686
    #15752015

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui added the PR: test Adding missing tests or correcting existing test label Jun 10, 2024
@kthui kthui changed the title test: Non-decoupled models should filter outputs based on requested outputs test: Python models filtering outputs based on requested outputs Jun 11, 2024
@kthui kthui force-pushed the jacky-py-req-output branch from 6b4e556 to 303f4e3 Compare June 11, 2024 01:09
@kthui kthui force-pushed the jacky-py-req-output branch from 303f4e3 to 80238e0 Compare June 11, 2024 01:16
@kthui kthui marked this pull request as ready for review June 11, 2024 16:11
@kthui kthui requested review from rmccorm4, Tabrizian and GuanLuo June 11, 2024 16:15
rmccorm4
rmccorm4 previously approved these changes Jun 11, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Also need a sanity check that L0_batcher tests pass with the python_backend change as well Confirmed L0_batcher passes same pipeline.

Tabrizian
Tabrizian previously approved these changes Jun 11, 2024
@kthui kthui dismissed stale reviews from rmccorm4 and Tabrizian via b6e10f8 June 11, 2024 22:03
@kthui kthui requested review from Tabrizian and rmccorm4 June 11, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: test Adding missing tests or correcting existing test
Development

Successfully merging this pull request may close these issues.

4 participants