Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add default template that diverts to sub templates #7306

Merged
merged 3 commits into from
May 30, 2024
Merged

docs: Add default template that diverts to sub templates #7306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a81d5e0
added top level template to dirvert to different templates
jbkyang-nvi May 30, 2024
c24a0ae
update default template
jbkyang-nvi May 30, 2024
505f449
update copyright
jbkyang-nvi May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...REQUEST_TEMPLATE/pull_request_template.md → ...pull_request_template_internal_contrib.md
View file
Open in desktop
File renamed without changes.
13 changes: 13 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Thanks for submitting a PR to Triton!
Please go the the `Preview` tab above this description box and select the appropriate sub-template:

* [PR description template for Triton Engineers](?expand=1&template=pull_request_template_internal_contrib.md)
* [PR description template for External Contributors](?expand=1&template=pull_request_template_external_contrib.md)

If you already created the PR, please replace this message with one of
* [External contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_external_contrib.md)
* [Internal contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md)

and fill it out.


29 changes: 15 additions & 14 deletions qa/common/check_copyright.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,20 @@

FLAGS = None
SKIP_EXTS = (
"jpeg",
"jpg",
"pgm",
"png",
"log",
"preprocessed",
"jmx",
"gz",
"json",
"pdf",
"so",
"onnx",
"svg",
".jpeg",
".jpg",
".pgm",
".png",
".log",
".preprocessed",
".jmx",
".gz",
".json",
".pdf",
".so",
".onnx",
".svg",
"pull_request_template.md",
)
REPO_PATH_FROM_THIS_FILE = "../.."
SKIP_PATHS = (
Expand Down Expand Up @@ -130,7 +131,7 @@ def visit(path):
print("visiting " + path)

for skip in SKIP_EXTS:
if path.endswith("." + skip):
if path.endswith(skip):
if FLAGS.verbose:
print("skipping due to extension: " + path)
return True
Expand Down
Loading