-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response sender test base #7254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4194256
to
27b8509
Compare
This was referenced May 22, 2024
27b8509
to
15b5e56
Compare
rmccorm4
reviewed
May 23, 2024
rmccorm4
reviewed
May 23, 2024
rmccorm4
reviewed
May 23, 2024
rmccorm4
reviewed
May 23, 2024
rmccorm4
reviewed
May 23, 2024
rmccorm4
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level overview of tests look good to me, left some comments.
Tabrizian
reviewed
May 30, 2024
bc3442e
to
576a381
Compare
576a381
to
84d1422
Compare
Tabrizian
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up the base for response sender testing, which enables testing varies ways a model may return response(s), including improper use of response sender.
Currently, this test only tests existing behaviors of decoupled and non-decoupled models, before any work is done on their data pipelines or response sender.
The control of testing is from the test script by setting the input tensors:
There are definite some improvements possible on the test base, i.e. reporting the size of requests, allow the final flag to be sent with the last response or separately, add support for dynamic batching requests. but I think those can be added (or already added) in next PRs when needed.
Next PRs: