Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC AsyncIO request cancellation tests (#6408) #6431

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add gRPC AsyncIO request cancellation tests (#6408) #6431

merged 1 commit into from
Oct 16, 2023

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Oct 13, 2023

  • Fix gRPC test failure and refactor

  • Add gRPC AsyncIO cancellation tests

  • Better check if a request is cancelled

  • Use f-string

@kthui
Add gRPC AsyncIO request cancellation tests (#6408)
18eefe4 
* Fix gRPC test failure and refactor

* Add gRPC AsyncIO cancellation tests

* Better check if a request is cancelled

* Use f-string
@kthui kthui requested review from jbkyang-nvi and mc-nv October 13, 2023 21:01
@kthui kthui marked this pull request as ready for review October 13, 2023 21:01
@mc-nv mc-nv merged commit f40c914 into r23.10 Oct 16, 2023
3 checks passed
@kthui kthui deleted the jacky-req-cancel-aio-r23.10 branch February 12, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc-nv mc-nv mc-nv approved these changes

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@jbkyang-nvi jbkyang-nvi Awaiting requested review from jbkyang-nvi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kthui @tanmayv25 @mc-nv