Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix L0_java_memory_growth #6275

Closed
wants to merge 1 commit into from
Closed

Fix L0_java_memory_growth #6275

wants to merge 1 commit into from

Conversation

nv-kmcgill53
Copy link
Contributor

Compilation inside the test is failing due to cmake and rapidjson-dev not being installed.

Adding these pre-requisites doesn't solve the runtime issue. Once a solution is found, it will need to be implemented before this can be merged.

Tabrizian
Tabrizian approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how the test worked before without these packages.

@nv-kmcgill53
Copy link
Contributor Author

I wonder how the test worked before without these packages.

Last pass was on 2023-06-29

@jbkyang-nvi
Copy link
Contributor

cmake and rapidjson shouldn't be needed for this test. I'll take a look into this

@jbkyang-nvi jbkyang-nvi mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@jbkyang-nvi jbkyang-nvi Awaiting requested review from jbkyang-nvi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nv-kmcgill53 @jbkyang-nvi @Tabrizian