-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling nested spans for trace mode OpenTelemetry #5928
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4486b5b
Nested spans commt before rebase
oandreeva-nv ce1d11f
Cleaning up and adjusting code for nested spans
oandreeva-nv a67c678
Restoring CMakeLists
oandreeva-nv 4b87533
Adjusted test
oandreeva-nv 7d0b5ea
test update
oandreeva-nv 7605fac
Major Revision
oandreeva-nv af0dbbf
Revision 2
oandreeva-nv 032b4a0
Revision 2: follow up
oandreeva-nv a1dd6a3
Revision 2: correction
oandreeva-nv 1b8f457
Revision 2: adding _WIN32 check
oandreeva-nv c9892dc
Added tests
oandreeva-nv 54a74c5
Changes based on codeql
oandreeva-nv 1cf76e4
Removed check of root span
oandreeva-nv 0216c1f
Fixed WIN build issue
oandreeva-nv 1073507
Revision 3
oandreeva-nv 7b77439
Added comments and small refactoring.
oandreeva-nv 191ece8
restoring src/command_line_parser.cc after rebase on main
oandreeva-nv 522c991
Revised PR, added ensemble test
oandreeva-nv 8342be2
Removed unused variable in test
oandreeva-nv 02da628
Rebase on main. Changes on test to avoid early exit
oandreeva-nv fd46dfb
Changed ternary to if-else
oandreeva-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed WIN build issue
- Loading branch information
commit 0216c1febd3e559e1ef3bbabbc650aa8fb8c1f52
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future improvement, we can derive subclass from
Trace
for different mode, i.e.OpenTelemetryTrace
,TritonTrace
and they implements aReport()
function which is going to beReportToOpenTelemetry
or thestringstream
appending belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this idea! I will add this to the refactoring ticket