Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore AWS_SECRET_ACCESS_KEY on S3 local test #5832

Merged
merged 2 commits into from
May 23, 2023
Merged

Restore AWS_SECRET_ACCESS_KEY on S3 local test #5832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
693b70c
Restore AWS_SECRET_ACCESS_KEY
kthui May 22, 2023
12a5449
Add reason for restoring keys
kthui May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions qa/L0_storage_S3_local/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ kill $SERVER_PID
wait $SERVER_PID

# Test access decline
AWS_SECRET_ACCESS_KEY_BACKUP=$AWS_SECRET_ACCESS_KEY
export AWS_SECRET_ACCESS_KEY="[Invalid]"
SERVER_ARGS="--model-repository=s3://localhost:4572/${BUCKET_NAME}1 --exit-timeout-secs=120"
SERVER_LOG="./inference_server.access_decline.log"
Expand All @@ -341,6 +342,8 @@ else
RET=1
fi
fi
# Restore keys for destroying buckets
export AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY_BACKUP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with reasons for resetting key to valid after invalid test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added: Add reason for restoring keys


# Destroy buckets
for BUCKET_SUFFIX in 1 2; do
Expand Down