Skip to content

Commit

Permalink
docs: Add default template that diverts to sub templates (#7306)
Browse files Browse the repository at this point in the history
This PR fixes this known github issue where multiple PR templates is not supported in Github.
It is an add on to PR# 7290
  • Loading branch information
jbkyang-nvi authored May 30, 2024
1 parent 353f24e commit 0df1fe7
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 14 deletions.
13 changes: 13 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Thanks for submitting a PR to Triton!
Please go the the `Preview` tab above this description box and select the appropriate sub-template:

* [PR description template for Triton Engineers](?expand=1&template=pull_request_template_internal_contrib.md)
* [PR description template for External Contributors](?expand=1&template=pull_request_template_external_contrib.md)

If you already created the PR, please replace this message with one of
* [External contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_external_contrib.md)
* [Internal contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md)

and fill it out.


29 changes: 15 additions & 14 deletions qa/common/check_copyright.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,20 @@

FLAGS = None
SKIP_EXTS = (
"jpeg",
"jpg",
"pgm",
"png",
"log",
"preprocessed",
"jmx",
"gz",
"json",
"pdf",
"so",
"onnx",
"svg",
".jpeg",
".jpg",
".pgm",
".png",
".log",
".preprocessed",
".jmx",
".gz",
".json",
".pdf",
".so",
".onnx",
".svg",
"pull_request_template.md",
)
REPO_PATH_FROM_THIS_FILE = "../.."
SKIP_PATHS = (
Expand Down Expand Up @@ -130,7 +131,7 @@ def visit(path):
print("visiting " + path)

for skip in SKIP_EXTS:
if path.endswith("." + skip):
if path.endswith(skip):
if FLAGS.verbose:
print("skipping due to extension: " + path)
return True
Expand Down

0 comments on commit 0df1fe7

Please sign in to comment.