Fix decoupled batch statistics to account for implicit batch size #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
This was referenced May 22, 2024
Tabrizian
approved these changes
May 23, 2024
This was referenced May 24, 2024
|
Rebase onto https://github.com/triton-inference-server/python_backend/tree/jacky-res-sender-main for merging. |
kthui
force-pushed
the
jacky-res-sender-fix-decouple-batch-stat
branch
from
89512e6 to
d5e12b9
Compare
kthui
added a commit
that referenced
this pull request
Jun 6, 2024
* Add response sender to non-decoupled models and unify data pipelines (#360) * Add response sender to non-decoupled model and unify data pipelines * Rename variable and class name * Fix decoupled batch statistics to account for implicit batch size (#361) * Fix decoupled gpu output error handling (#362) * Fix decoupled gpu output error handling * Return full error string upon exception from model * Response sender to check for improper non-decoupled model usage (#363) * Response sender to check for improper non-decoupled model usage * Force close response sender on exception * Rename functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PRs:
The decoupled metrics reporting should consider implicit batch size when reporting batch statistics. Previously, the batch statistics uses the number of requests as batch size, which does not account for batched request(s). Now, it is modified to take the number of requests multiplied by its respective implicit batch size.
Next PRs: