Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main branch post-23.12 release #331

Closed
wants to merge 2 commits into from
Closed

Update main branch post-23.12 release #331

wants to merge 2 commits into from

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Dec 20, 2023

No description provided.

@krishung5 @mc-nv
Fix BLS decoupled segfault and hang (#325) (#326)
f32a352 
* Store InferPayload using the address of the object managed by the shared_ptr

* Fix hang

* Release GIL before sending message to the other process

* Release GIL in the beginning
@krishung5 @mc-nv
Fix segfault for decoupled models (#327) (#328)
599a75e 
* Set release flags and clean up response factory map before returning error

* Address comments

* Move the cleanup function to the outside scope

* Delete response factory when response sender goes out of scope
@mc-nv mc-nv requested review from tanmayv25 and krishung5 December 20, 2023 21:41
@krishung5
Copy link
Contributor

I think it's overriding a new commit from main: #329

@mc-nv mc-nv closed this Dec 21, 2023
@mc-nv mc-nv deleted the mchornyi-main branch December 26, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

@krishung5 krishung5 Awaiting requested review from krishung5

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mc-nv @krishung5