Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to autocomplete pr #317 #320

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

oandreeva-nv
Copy link
Contributor

This is a follow up PR to : #317 . Unfortunately, I missed essential part.

After we retrieved updated model configuration from core during the call:

RETURN_IF_ERROR((*state)->SetModelConfig());

decoupled_ is not updated on the python backend site, since it is a part of ModelState.

I've added PropagateAutoCompletedConfig() that does exactly that, i.e. looks for model_transaction_policy in the model config (already filled by core), and if decoupled is found in model_transaction_policy , we update decoupled_ property.

Actual functionality is tested with vllm backend on this PR: triton-inference-server/vllm_backend#20

Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tanmayv25 tanmayv25 merged commit 60a9091 into main Nov 8, 2023
@tanmayv25 tanmayv25 deleted the oandreeva_autocomplete_followup branch November 8, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants