-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure cleaning up of the futures in decoupled mode #309
Conversation
Nice fix! Spoke offline, let's try to make the messages in these blocks also |
@rmccorm4 I tried using unique_ptr but for some reason it looks like it needs to be a |
Can you add a ticket to look into it later? I think it would be good to reduce future risk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on finding the root cause and fixing the leak!
0608545
to
fd4f8bb
Compare
@rmccorm4 Filed a ticket. |
* Restructure cleaning up of the futures in decoupled * Minor improvement
Fixes triton-inference-server/server#6270 (comment)
Huge shout out to @rmccorm4 for finding the root cause.