Add support for models with dynamic shapes #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrawins
reviewed
Mar 7, 2024
README.md
Outdated
| { | ||
| name: "input" | ||
| data_type: TYPE_FP32 | ||
| dims: [ -1, 3, -1, 224] |
There was a problem hiding this comment.
Suggested change
| dims: [ -1, 3, -1, 224] | |
| dims: [ -1, 3, -1, -1] |
There was a problem hiding this comment.
This is now inconsistent with comment in L209
Co-authored-by: Trawinski, Dariusz <[email protected]>
dtrawins
reviewed
Mar 8, 2024
README.md
Outdated
|
|
||
| Following section shows how to use OpenVINO dynamic shapes. `-1` denotes dimension accepting any value on input. In this case | ||
| while model originally accepted input with layout `NCHW` and shape `(1,3,224,224)`, now it accepts any batch size and height. |
There was a problem hiding this comment.
Suggested change
| while model originally accepted input with layout `NCHW` and shape `(1,3,224,224)`, now it accepts any batch size and height. | |
| while model originally accepted input with layout `NCHW` and shape `(1,3,224,224)`, now it accepts any batch size and resolution. |
…i/triton_openvino_backend into atobisze_dynamic_shapes
dtrawins
approved these changes
Mar 8, 2024
nv-kmcgill53
pushed a commit
that referenced
this pull request
Mar 8, 2024
This reverts commit a68ca46.
nv-kmcgill53
added a commit
that referenced
this pull request
Mar 9, 2024
This reverts commit a68ca46. Co-authored-by: kyle <[email protected]>
atobiszei
added a commit
to atobiszei/triton_openvino_backend
that referenced
this pull request
Mar 11, 2024
dtrawins
pushed a commit
that referenced
this pull request
Mar 13, 2024
nv-kmcgill53
pushed a commit
that referenced
this pull request
Mar 15, 2024
nv-kmcgill53
added a commit
that referenced
this pull request
Mar 16, 2024
* Revert "Revert "Add support for models with dynamic shapes (#69)" (#70)" This reverts commit 25934f6. * Fix building after style fixes Co-authored-by: Adrian Tobiszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.