build: Improves python packaging infrastructure #414
+67
−821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
commented
Nov 22, 2024
|
|
||
| if "--plat-name" in sys.argv: |
There was a problem hiding this comment.
Doesn't seem like this was ever used. Not sure if it's needed in the new build flow
pranavm-nvidia
commented
Nov 22, 2024
|
|
||
| os.chdir(FLAGS.whl_dir) | ||
| print("=== Building wheel") | ||
| args = ["python3", "setup.py", "bdist_wheel"] | ||
| args = ["python3", "-m", "build"] |
There was a problem hiding this comment.
Not sure how to make sure the build package is installed in the containers.
There was a problem hiding this comment.
TODO: I need to double check this
There was a problem hiding this comment.
Started pipeline: 21638660
There was a problem hiding this comment.
Yep will need to install this in build container too
/usr/bin/python3: No module named build
error: Building wheel failed failed
I believe that would go here for RHEL and Ubuntu builds:
There was a problem hiding this comment.
I will try this out - pipeline 21672308
pranavm-nvidia
force-pushed
the
packaging
branch
from
453dc31 to
b3d03f0
Compare
|
Need to run CI |
rmccorm4
changed the title
rmccorm4
reviewed
Dec 13, 2024
Updates the Python package to use `build` to package instead of the legacy `bdist_wheel` style. `pyproject.toml` is the single source of truth for the package. Additionally, this change also move stub generation to `setup.py` so that it happens automatically when the wheels are generated. This way the stub files don't need to be maintained in the repo and manually updated.
pranavm-nvidia
force-pushed
the
packaging
branch
from
b3d03f0 to
a520e4a
Compare
rmccorm4
reviewed
Dec 16, 2024
rmccorm4
reviewed
Dec 19, 2024
Co-authored-by: Ryan McCormick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Python package to use
buildto package instead of the legacybdist_wheelstyle.pyproject.tomlis the single source of truth for the package.Additionally, this change also move stub generation to
setup.pyso that it happens automatically when the wheels are generated. This way the stub files don't need to be maintained in the repo and manually updated.