fix: Preserve Sequence Flags in Ensemble models #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrajit96
force-pushed
the
identity_ensemble_flag_ibhosale
branch
from
cd29411 to
c43bda7
Compare
|
Update title |
indrajit96
changed the title
rmccorm4
changed the title
|
Can you elaborate in the description why the reverted changes were breaking the propagation? And do the reverted changes need to come back at some point (in some modified way to not break this) for other reasons? |
indrajit96
changed the title
rmccorm4
changed the title
rmccorm4
approved these changes
Jun 12, 2024
rmccorm4
pushed a commit
that referenced
this pull request
Jun 14, 2024
indrajit96
added a commit
that referenced
this pull request
Jun 17, 2024
nv-kmcgill53
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert changes made in e978d80 to ensure START and END flags are propagated correctly in ensemble models.
RCA : Any ensemble inference request where the user sets the flags "sequence_start" and "sequence_end" was getting ignored.
Fix : We now check if the request had the FLAGS set and then pass them forward as is.
Future scope : This was a bug introduced in e978d80 which was intended to clean up code. We do not expect these changes to come back again.
Have added a TC in triton-inference-server/server#7344 to ensure regression in future.