-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version info to prometheus metrics #272
base: main
Are you sure you want to change the base?
Add version info to prometheus metrics #272
Conversation
Thanks for contributing this! Have you submitted a CLA yet? |
I think the CLA finally got sorted. I should be good to go. |
@dyastremsky Is there anything I can do to further this PR? |
39b1b02
to
9255275
Compare
Signed-off-by: Clif Houck <[email protected]>
Signed-off-by: Clif Houck <[email protected]>
9255275
to
ab8e129
Compare
Thank you for submitting your CLA, Clif! Apologies for the delay. Ryan and Olga, do these look good to you? The original issue mentioned exposing the version info via Prometheus as one way of addressing the need to see Triton version info. Do we want these to be accessible via Prometheus? |
// Versions | ||
version_info_family_( | ||
prometheus::BuildGauge() | ||
.Name("triton_version_information") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ClifHouck, thanks for the contrbution.
I reached out on the original issue to clarify the ask - I'm not sure if server/backend API versions are necessary for the original ask if the actual triton release version is reflected and can be mapped.
However, it does raise a question that this extra level of detail may be useful to add to an existing endpoint. Do you have any reasoning on exposing these through prometheus rather than another existing REST endpoint? Pros of adding it to a standard (non-metrics) endpoint is that it would always be available, regardless of whether the server was built or configured at runtime to use prometheus metrics or not.
Addresses triton-inference-server/server#6320
Example metric output:
$ curl -s --request GET "http://localhost:8002/metrics" | grep api triton_version_information{api_major_version="1",api_minor_version="16",server_major_version="1",server_minor_version="24"} 0